Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace discover threat hunting #6254

Merged
merged 16 commits into from
Jan 5, 2024
Merged

Replace discover threat hunting #6254

merged 16 commits into from
Jan 5, 2024

Conversation

Machi3mfl
Copy link
Member

@Machi3mfl Machi3mfl commented Dec 29, 2023 •
edited
Loading

Description

This PR, adds and replaces the events tab on the Threat hunting module

Closes #6236

Screenshot 2023-12-29 at 01 01 56

Tests

Search bar

Test Chrome Firefox Safari
Apply filters using search bar input ⚫ ⚫ ⚫
Apply filters using the search bar add filter feature ⚫ ⚫ ⚫
Apply filters using the date picker ⚫ ⚫ ⚫
Apply filters with no results (Check the No results match your search criteria message) ⚫ ⚫ ⚫
Use the saved queries feature (Check saved queries CRUD) ⚫ ⚫ ⚫
  • Apply filters using search bar input
Screen.Recording.2024-01-04.at.11.07.22.mov
  • Apply filters using the search bar add filter feature
Screen.Recording.2024-01-04.at.11.08.53.mov
  • Apply filters using the date picker
Screen.Recording.2024-01-04.at.11.09.33.mov
  • Apply filters with no results (Check the No results match your search criteria message)
Screen.Recording.2024-01-04.at.11.06.29.mov
  • Use the saved queries feature (Check saved queries CRUD)
Screen.Recording.2024-01-04.at.11.10.16.mov

Histogram chart

Test Chrome Firefox Safari
Check histogram chart hits consistency ⚫ ⚫ ⚫
Use chart options (three points: maximize, minimize, inspect) ⚫ ⚫ ⚫
  • Check histogram chart hits consistency
Screen.Recording.2024-01-04.at.10.39.41.mov
  • Use chart options (three points: maximize, minimize, inspect)
Screen.Recording.2024-01-04.at.10.36.52.mov

Data grid

Test Chrome Firefox Safari
Check all table header features (sort, show/hide columns, density, etc) ⚫ ⚫ ⚫
Check table pagination and rows per page ⚫ ⚫ ⚫
Check document detail flyout ⚫ ⚫ ⚫
  • Check all table header features (sort, show/hide columns, density, etc)
Screen.Recording.2024-01-04.at.11.00.25.mov
  • Check table pagination and rows per page
Screen.Recording.2024-01-04.at.11.01.57.mov
  • Check document detail flyout
Screen.Recording.2024-01-04.at.11.02.54.mov

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@Machi3mfl Machi3mfl changed the title Feat/6236 replace discover threat hunting replace discover threat hunting Jan 2, 2024
@Machi3mfl Machi3mfl changed the title replace discover threat hunting Replace discover threat hunting Jan 2, 2024
@Machi3mfl Machi3mfl marked this pull request as ready for review January 4, 2024 14:12
@Machi3mfl Machi3mfl requested a review from a team as a code owner January 4, 2024 14:12
@yenienserrano
Copy link
Member

yenienserrano commented Jan 4, 2024 •
edited
Loading

Search bar

Test Chrome Firefox Safari
Apply filters using search bar input 🟢 ⚫ ⚫
Apply filters using the search bar add filter feature 🟢 ⚫ ⚫
Apply filters using the date picker 🟢 ⚫ ⚫
Apply filters with no results (Check the No results match your search criteria message) 🟢 ⚫ ⚫
Use the saved queries feature (Check saved queries CRUD) 🟢 ⚫ ⚫
  • Apply filters using search bar input

image

  • Apply filters using the search bar add filter feature

image

  • Apply filters using the date picker

image
image

  • Apply filters with no results (Check the No results match your search criteria message)

image

  • Use the saved queries feature (Check saved queries CRUD)

image
image
image
image
image
image
image

Histogram chart

Test Chrome Firefox Safari
Check histogram chart hits consistency 🟢 ⚫ ⚫
Use chart options (three points: maximize, minimize, inspect) 🟢 ⚫ ⚫
  • Check histogram chart hits consistency

image
image

  • Use chart options (three points: maximize, minimize, inspect)

image
image
image

Data grid

Test Chrome Firefox Safari
Check all table header features (sort, show/hide columns, density, etc) 🔴 ⚫ ⚫
Check table pagination and rows per page 🟢 ⚫ ⚫
Check document detail flyout 🟢 ⚫ ⚫
  • Check all table header features (sort, show/hide columns, density, etc)
show/hide columns 🔴 when I try to move a field from one place to another, I see a red square that occupies all the options.

image
image
image

density
image
image

full screen
image

sort
image
image

  • Check table pagination and rows per page

image
image
image

  • Check document detail flyout

image

@asteriscos
Copy link
Member

asteriscos commented Jan 4, 2024 •
edited
Loading

Search bar

Test Chrome Firefox Safari
Apply filters using search bar input 🟢 🟢 ⚪
Apply filters using the search bar add filter feature 🟢 🟢 ⚪
Apply filters using the date picker 🟢 🟢 ⚪
Apply filters with no results (Check the No results match your search criteria message) 🟢 🟢 ⚪
Use the saved queries feature (Check saved queries CRUD) 🟢 🟢 ⚪
  • Apply filters using search bar input

Peek 2024-01-04 17-51

  • Apply filters using the search bar add filter feature

Peek 2024-01-04 17-51

  • Apply filters using the date picker

Peek 2024-01-04 17-54

  • Apply filters with no results (Check the No results match your search criteria message)

image

  • Use the saved queries feature (Check saved queries CRUD)

image

Histogram chart

Test Chrome Firefox Safari
Check histogram chart hits consistency 🟢 🟢 ⚪
Use chart options (three points: maximize, minimize, inspect) 🟢 🟢 ⚪
  • Check histogram chart hits consistency

image

image

  • Use chart options (three points: maximize, minimize, inspect)

Peek 2024-01-05 20-12

Data grid

Test Chrome Firefox Safari
Check all table header features (sort, show/hide columns, density, etc) 🟡 🟡 ⚪
Check table pagination and rows per page 🟢 🟢 ⚪
Check document detail flyout 🟢 🟢 ⚪
  • Check all table header features (sort, show/hide columns, density, etc)

Everything seems to work fine except for the drag and drop feature. The issue can be replicated in the new Discover OpenSearch plugin.

Peek 2024-01-05 20-28

image

  • Check table pagination and rows per page

Peek 2024-01-05 20-31

  • Check document detail flyout

Screenshot from 2024-01-05 20-29-16

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 5, 2024

Wazuh Core plugin code coverage (Jest) test % values
Statements 22.02% ( 176 / 799 )
Branches 19.55% ( 79 / 404 )
Functions 14.63% ( 36 / 246 )
Lines 22.23% ( 173 / 778 )

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 5, 2024

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.33% ( 171 / 224 )
Branches 57.57% ( 57 / 99 )
Functions 61.7% ( 29 / 47 )
Lines 76.33% ( 171 / 224 )

yenienserrano
yenienserrano approved these changes Jan 5, 2024
View reviewed changes
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 5, 2024

Main plugin code coverage (Jest) test % values
Statements 11.41% ( 3918 / 34333 )
Branches 7.55% ( 1715 / 22687 )
Functions 11% ( 903 / 8204 )
Lines 11.58% ( 3807 / 32870 )

@asteriscos asteriscos merged commit c1329d8 into master Jan 5, 2024
4 checks passed
@asteriscos asteriscos deleted the feat/6236-replace-discover-threat-hunting branch January 5, 2024 17:42
@asteriscos asteriscos mentioned this pull request Aug 21, 2024
Closed
74 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yenienserrano yenienserrano yenienserrano approved these changes

@asteriscos asteriscos asteriscos approved these changes

Assignees

@Machi3mfl Machi3mfl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Remove discover] Replace discover on threat hunting module
3 participants
@Machi3mfl @yenienserrano @asteriscos